fix(tests): resolve 3 skipped model directory tests (Section 3/5) #632
+31
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for vllm-semantic-router ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
👥 vLLM Semantic Team NotificationThe following members have been identified for the changed files in this PR and have been automatically assigned: 📁
|
yehudit1987
force-pushed
the
fix_skipped_tests_clean
branch
from
be4e510 to
ace578b
Compare
yehudit1987
requested review from
Xunzhuo,
rootfs and
wangchen615
as code owners
Collaborator
|
@yuluo-yx PTAL, thanks |
yehudit1987
force-pushed
the
fix_skipped_tests_clean
branch
3 times, most recently
from
368f71b to
608c921
Compare
yuluo-yx
reviewed
Nov 15, 2025
.github/workflows/test-and-build.yml
Outdated
| path: | | ||
| models/ | ||
| key: ${{ runner.os }}-models-v1-${{ hashFiles('tools/make/models.mk') }} | ||
| key: ${{ runner.os }}-models-v2-${{ hashFiles('tools/make/models.mk') }} |
Contributor
There was a problem hiding this comment.
Why is v2 being used here? Is it really necessary for us to upgrade to v2? The model files are very large and will occupy a lot of cache space on GitHub.
yuluo-yx
reviewed
Nov 15, 2025
| func TestAutoDiscoverModels_RealModels(t *testing.T) { | ||
| // Test with real models directory | ||
| modelsDir := "../../../../../models" | ||
| modelsDir := "../../../../models" |
Contributor
There was a problem hiding this comment.
Can we define it as a constant? This is used in many places.
yehudit1987
force-pushed
the
fix_skipped_tests_clean
branch
from
608c921 to
33a0857
Compare
Signed-off-by: Yehudit Kerido <[email protected]>
yehudit1987
force-pushed
the
fix_skipped_tests_clean
branch
from
33a0857 to
d527146
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests TestAutoDiscoverModels_RealModels, TestAutoInitializeUnifiedClassifier,
and TestUnifiedClassifier_Integration now pass.
Fix Partially issue #573